Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Shadow queue hard coded variables #327

Merged
merged 4 commits into from
Jan 27, 2025
Merged

fix: Shadow queue hard coded variables #327

merged 4 commits into from
Jan 27, 2025

Conversation

zacharyblasczyk
Copy link
Contributor

No description provided.

dacbd
dacbd approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the intention is they would be added as an extraEnv when required?

@zacharyblasczyk
Copy link
Contributor Author

I'm assuming the intention is they would be added as an extraEnv when required?

Yes, the intent for this configuration at the moment should be that it is enabled on a case by case basis, not defaulted here.

@zacharyblasczyk zacharyblasczyk merged commit 1f2b56f into main Jan 27, 2025
1 of 2 checks passed
@zacharyblasczyk zacharyblasczyk deleted the zacharyb/fix-shadow-queue branch January 27, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd approved these changes

@jsbroks jsbroks Awaiting requested review from jsbroks jsbroks is a code owner

@vanpelt vanpelt Awaiting requested review from vanpelt vanpelt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyblasczyk @dacbd